support/log: add log fatal functions #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've been using `log.Panic` for initialization. Panic should be used on unexpected things. In our case, it is likely that the user doesn't have the right configs to spin up our server.
… will lose the test
ire-and-curses
approved these changes
Mar 11, 2019
services/horizon/internal/init.go
Outdated
| session, err := db.Open("postgres", app.config.DatabaseURL) | ||
| if err != nil { | ||
| log.Panic(err) | ||
| log.Fatalf("cannot open Horizon DB due to error %v", err) |
There was a problem hiding this comment.
Message might be better as "cannot open Horizon DB: %v", err (this is how the errors.wrap module does it)
services/horizon/internal/init.go
Outdated
| session, err := db.Open("postgres", app.config.StellarCoreDatabaseURL) | ||
| if err != nil { | ||
| log.Panic(err) | ||
| log.Fatalf("cannot open core DB due to error %v", err) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been using
log.Panicfor initialization. Panic should be used onunexpected things. In our case, it is likely that the user doesn't have
the right configs to spin up our server.