Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

paymentservice: code polishes #2

Merged
merged 9 commits into from
Jan 31, 2022
Merged

paymentservice: code polishes #2

merged 9 commits into from
Jan 31, 2022

Conversation

marcelosalloum
Copy link
Contributor

@marcelosalloum marcelosalloum commented Jan 28, 2022 •
edited
Loading

What

Polished code from the paymentservice module in order to make it ready for the next features.

Changes:

  • Removed AccountType to use the new object Account.Capabilities, for improved clarity.
  • Fix async test testGetAccount_isNotMainAccount that was failing intermittently.
  • Update sendPayment signature so it can represent payments from one network to another, e.g. Circle->Stellar.
  • Rename package paymentsservice to use the singular form paymentservice.
  • Add or update comments to improve clarity.

@marcelosalloum marcelosalloum self-assigned this Jan 28, 2022
@marcelosalloum marcelosalloum changed the title paymentsgateway: code polishes paymentsservice: code polishes Jan 28, 2022
Base automatically changed from cd-ci to main January 28, 2022 18:43
@marcelosalloum marcelosalloum marked this pull request as ready for review January 28, 2022 19:04
@lijamie98
Copy link
Collaborator

LGTM since there is no Circle specific implementations. I think Jake can do a better review on the payment gateway interface.

@marcelosalloum marcelosalloum changed the title paymentsservice: code polishes paymentservice: code polishes Jan 31, 2022
@marcelosalloum marcelosalloum merged commit e0ed842 into main Jan 31, 2022
@marcelosalloum marcelosalloum deleted the payments-polish branch January 31, 2022 20:38
@reecexlm reecexlm added this to the Payment-Circle milestone Feb 8, 2022
@marcelosalloum marcelosalloum mentioned this pull request Feb 18, 2022
Closed
26 tasks
@marcelosalloum marcelosalloum linked an issue Feb 18, 2022 that may be closed by this pull request
Implement payments gateway interface for the Circle API #4
Closed
26 tasks
lijamie98 added a commit that referenced this pull request Apr 28, 2022
@lijamie98
Gradle project restructure #2 (#222)
c154a03 
* Created api-schema
* Created integration-tests
* Created service-runner
* Renamed payment-circle to payment
reecexlm added a commit that referenced this pull request Aug 4, 2022
@reecexlm
empty #2
a89c8ff
reecexlm added a commit that referenced this pull request Aug 4, 2022
@reecexlm
empty #2
93afc44
lijamie98 added a commit that referenced this pull request Aug 4, 2022
@lijamie98 @reecexlm
issue-457: Update distributionWallet fields. (#458)
bcd8561 
* add distributionWallet to reference server and make the default distribution wallet consistent with the assets.json

* empty #2

* empty #2

* bump helm chart

Co-authored-by: Reece Markowsky <reece@stellar.org>
lijamie98 added a commit that referenced this pull request Jun 6, 2023
@lijamie98
trigger test re-run #2
2668094
lijamie98 added a commit that referenced this pull request Jun 8, 2023
@lijamie98
Fix warnings
14afd2a 
trigger test re-run #2

trigger test re-run #3

trigger test re-run #4

trigger test re-run #5

trigger test re-run #6

trigger test re-run #7

trigger test re-run #8

trigger test re-run #9

trigger test re-run #10

Close spring application before exit

Mark threads daemon for scheduled tasks

Fix bugs

more fixes

empty commit

empty commit

empty commit

empty commit

empty commit

empty commit

empty commit

empty commit

try to shutdown servers all the time

empty

empty

do not exit after close
lijamie98 added a commit that referenced this pull request Jun 8, 2023
@lijamie98
empty #2
414018d
lijamie98 added a commit that referenced this pull request Jun 8, 2023
@lijamie98
empty #2
39611d8
lijamie98 added a commit that referenced this pull request Jun 8, 2023
@lijamie98
empty #1
962121b 
empty #2
lijamie98 added a commit that referenced this pull request Jun 8, 2023
@lijamie98
empty #2
7cdccf1
lijamie98 added a commit that referenced this pull request Jun 9, 2023
@lijamie98
take care of PR review #2
1ca39b6
philipliu added a commit that referenced this pull request Jun 20, 2023
@philipliu
Merge pull request #956 from philipliu/release/2.1.0
f1cea1f 
Merge main into release/2.1.0 (Attempt #2)
JiahuiWho referenced this pull request in JiahuiWho/java-stellar-anchor-sdk Sep 27, 2023
@lijamie98
revert client_id to token's account #2
ca14b8a
lijamie98 added a commit that referenced this pull request Dec 14, 2023
@lijamie98
temporarily comment out tests #2
7def380
lijamie98 added a commit that referenced this pull request May 9, 2024
@lijamie98
Retry tests #2
5b2745e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lijamie98 lijamie98 lijamie98 approved these changes

@JakeUrban JakeUrban JakeUrban approved these changes

Assignees

@marcelosalloum marcelosalloum

Labels
anchor platform mvp payment gateway
Projects
None yet
Milestone
Payment-Circle
Development

Successfully merging this pull request may close these issues.

Implement payments gateway interface for the Circle API
4 participants
@marcelosalloum @lijamie98 @JakeUrban @reecexlm