payment-circle: extend sendPayment functionality to allow sendding Circle->BankWire payments
#21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelosalloum
requested review from
JakeUrban and
lijamie98
and removed request for
JakeUrban
lijamie98
approved these changes
Feb 2, 2022
JakeUrban
reviewed
Feb 2, 2022
...ent-circle/src/main/java/org/stellar/anchor/paymentservice/circle/CirclePaymentsService.java
Outdated
Show resolved
Hide resolved
...ent-circle/src/main/java/org/stellar/anchor/paymentservice/circle/CirclePaymentsService.java
Outdated
Show resolved
Hide resolved
payment-circle/src/main/java/org/stellar/anchor/paymentservice/circle/model/CircleWallet.java
Outdated
Show resolved
Hide resolved
…ing the Network.BANK_WIRE send & receive capabilities.
marcelosalloum
force-pushed
the
payments-send-payout
branch
from
4402412
to
684603f
Compare
…ult from sendTransfer and sendPayout have the capabilities correctly configured.
|
I'm merging this PR to unblock Jamie. I can address further feedback in the next one. |
lijamie98
pushed a commit
that referenced
this pull request
Feb 3, 2022
…ircle->BankWire` payments (#21) Extend sendPayment functionality to allow sendding `Circle->BankWire` payments. This is a feature that one of our potential adopters needs and it's likely most partners will need it too.
lijamie98
pushed a commit
that referenced
this pull request
Feb 3, 2022
…ircle->BankWire` payments (#21) Extend sendPayment functionality to allow sendding `Circle->BankWire` payments. This is a feature that one of our potential adopters needs and it's likely most partners will need it too.
26 tasks
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
paymentservice.stellar, orallordocif the changes are broad or impact manypackages.
Thoroughness
What
Extend sendPayment functionality to allow sendding
Circle->BankWirepayments.Why
This is a feature that one of our potential adopters needs and it's likely most partners will need it too.