Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix code formatting in the CirclePaymentServiceTest file #27

Merged
merged 1 commit into from
Feb 4, 2022
Merged

test: fix code formatting in the CirclePaymentServiceTest file #27

merged 1 commit into from
Feb 4, 2022

Conversation

marcelosalloum
Copy link
Contributor

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    paymentservice.stellar, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.

What

Fix code formatting in the CirclePaymentServiceTest file.

Why

It wasn't formatted properly on #24 and we need it in the proper formatting before we continue to make changes to the file.

@marcelosalloum marcelosalloum self-assigned this Feb 3, 2022
Base automatically changed from circle-send-payment-polishes to main February 4, 2022 14:34
@marcelosalloum marcelosalloum merged commit 6bd7e24 into main Feb 4, 2022
@marcelosalloum marcelosalloum deleted the fix-test-formatting branch February 4, 2022 20:08
@marcelosalloum marcelosalloum mentioned this pull request Feb 18, 2022
Closed
26 tasks
@marcelosalloum marcelosalloum linked an issue Feb 18, 2022 that may be closed by this pull request
Implement payments gateway interface for the Circle API #4
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeUrban JakeUrban JakeUrban approved these changes

@lijamie98 lijamie98 Awaiting requested review from lijamie98

Assignees

@marcelosalloum marcelosalloum

Labels
anchor platform mvp payment gateway
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement payments gateway interface for the Circle API
2 participants
@marcelosalloum @JakeUrban