Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

payment-circle: gather payment history for BankWire->CircleWallet transfers #87

Merged
merged 5 commits into from
Mar 2, 2022

Conversation

marcelosalloum
Copy link
Contributor

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    paymentservice.stellar, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.

What

Update getAccountPaymentHistory so it includes the incoming payments, retrievable from Circle's /v1/payments endpoint.

Why

This was the last missing piece to build the account history.

@marcelosalloum marcelosalloum self-assigned this Feb 25, 2022
@marcelosalloum marcelosalloum changed the title payment-circle: gather payment history for BankWire->CircleWallet transfers payment-circle: gather payment history for BankWire->CircleWallet transfers Feb 25, 2022
@marcelosalloum marcelosalloum marked this pull request as ready for review February 25, 2022 15:11
@marcelosalloum marcelosalloum requested review from JakeUrban and lijamie98 and removed request for JakeUrban February 25, 2022 15:12
@marcelosalloum marcelosalloum merged commit c3fe0c9 into main Mar 2, 2022
@marcelosalloum marcelosalloum deleted the circle-get-incoming-deposits branch March 2, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants