Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

payment-circle: polish responses and code #88

Merged
merged 10 commits into from
Mar 2, 2022
Merged

Conversation

marcelosalloum
Copy link
Contributor

@marcelosalloum marcelosalloum commented Feb 25, 2022

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    paymentservice.stellar, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.

What

Code polishes and small fixes. Changes details:

  • Add CircleWallet.defaultCapabilities() and CircleWallet.merchantAccountCapabilities() to avoid hardcoding the capabilities every time.
  • Update Account default balances and unsettledBalances values to null, so the JSON response works better when we don't have the balances. Otherwise, returning an empty list passes the impression the balances are empty when that might not be the case.
  • Fix paginated responses cursors.
  • Updated docs on how to get the bank deposit instructions.
  • Solve warnings
  • Update CirclePaymentServiceTest to reduce code repetition and standardize method names.
  • Add all Circle asset names to the CircleAsset class, so we don't need to hardcode the string names.

Base automatically changed from circle-get-incoming-deposits to main March 2, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants