Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare assets by integer rather than by object #758

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Jun 27, 2024

This increases cross-compatibility across different instances of stellar-base by comparing integers rather than objects (which will be != given two different bases).

Copy link

Size Change: +48 B (0%)

Total Size: 3.21 MB

Filename Size Change
dist/stellar-base.js 2.35 MB +24 B (0%)
dist/stellar-base.min.js 855 kB +24 B (0%)

compressed-size-action

Copy link

@psheth9 psheth9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !!

@Shaptic Shaptic merged commit 212ebf5 into master Jun 27, 2024
8 checks passed
@Shaptic Shaptic deleted the better-asset-comparison branch June 27, 2024 19:40
@Shaptic Shaptic mentioned this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants