Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initialize.sh compiles in /target folder but then is looking in /target-tiny #58

Closed
esteblock opened this issue Nov 16, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@esteblock
Copy link
Contributor

What did you do?

./initialize.sh sandbox

What did you expect to see?

Contracts deploy sucessfully

What did you see instead?

got the following result:

Deploy the token contract
Build the crowdfund contract
cargo fmt --all
cargo build --target wasm32-unknown-unknown --release

---

Finished release [optimized] target(s) in 34.23s
cd target/wasm32-unknown-unknown/release/ && \
	for i in *.wasm ; do \
		ls -l "$i"; \
	done
-rwxrwxr-x 2 user user 8731 nov 16 hh:hh soroban_crowdfund_contract.wasm
Deploy the crowdfund contract
error: reading file target-tiny/wasm32-unknown-unknown/release/soroban_crowdfund_contract.wasm: No such file or directory (os error 2)


This is because in initialize.sh line 53 is calling make build and not `make

I think that for example porpose, needs to stay as make build
and hence, change in initialize.sh to look into /targetfolder, and not into /target-tiny folder

@esteblock esteblock added the bug Something isn't working label Nov 16, 2022
@esteblock
Copy link
Contributor Author

I saw that this was added here:
#44

However stills calls to make build and not make build-optimized

If we wanna use make build-optimizedwe also need to add on the instructions to Install Rust nightly

https://soroban.stellar.org/docs/tutorials/build-optimized

@esteblock
Copy link
Contributor Author

As is intend to be for begginers, I suggest not to use optimizing builds.
Created PR

@paulbellamy
Copy link
Contributor

Makes sense, especially given stellar/stellar-cli#236

@paulbellamy
Copy link
Contributor

Closed in #60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants