bugfix: Supply captive core path for toml generation #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When missing the captive core binary, toml generation doesn't take Core's version and protocol into consideration, conservatively missing version-dependent default config options. This caused default options like `EXPERIMENTAL_BUCKETLIST_DB` and `ENABLE_SOROBAN_DIAGNOSTIC_EVENTS` to be missing. Due to its implications, `CoreBinaryPath` should not be an optional parameter.
tamirms
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When missing the captive core binary, toml generation doesn't take Core's version and protocol into consideration, conservatively avoiding version-dependent default config options.
This causes default options like
EXPERIMENTAL_BUCKETLIST_DBandENABLE_SOROBAN_DIAGNOSTIC_EVENTSto be missing.Due to its implications,
CoreBinaryPathshould not be an optional parameter.