Feat/speculos test framework #1347
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of adding one to the signer crate
this helped get past the lifetime complexity
elizabethengelman
force-pushed
the
feat/speculos-test-framework
branch
from
3ebc3d5
to
4c4bbfe
Compare
| @@ -219,7 +199,7 @@ async fn test_sign_tx_hash_when_hash_signing_is_enabled() { | |||
| let ledger = Arc::clone(&ledger); | |||
| async move { ledger.sign_transaction_hash(path, &test_hash).await } | |||
| }); | |||
| let approve = tokio::task::spawn(approve_tx_hash_signature(ui_host_port)); | |||
| let approve = tokio::task::spawn(approve_tx_hash_signature_2(&ledger_testing)); | |||
There was a problem hiding this comment.
When trying to use ledger_testing in approve_tx_hash_signature I am seeing an error that I can't quite seem to solve. I think that the issue is that in testcontainers, once the container goes out of scope it drops the docker reference. And then we can't use it again here. I've played around with using Arcs and RefCells, and may be missing something and would love another set of eyes on this!
For reference, this test passes without the most recent commit.
There was a problem hiding this comment.
The errors:
error[E0597]: `docker` does not live long enough
--> cmd/crates/stellar-ledger/src/emulator_tests.rs:176:77
|
175 | let docker = clients::Cli::default();
| ------ binding `docker` declared here
176 | let ledger_testing = LedgerTesting::new(apps_dir(), LedgerModel::NanoS, &docker);
| ^^^^^^^ borrowed value does not live long enough
...
202 | let approve = tokio::task::spawn(approve_tx_hash_signature_2(&ledger_testing));
| -------------------------------------------- argument requires that `docker` is borrowed for `'static`
...
215 | }
| - `docker` dropped here while still borrowed
error[E0597]: `ledger_testing` does not live long enough
--> cmd/crates/stellar-ledger/src/emulator_tests.rs:202:66
|
176 | let ledger_testing = LedgerTesting::new(apps_dir(), LedgerModel::NanoS, &docker);
| -------------- binding `ledger_testing` declared here
...
202 | let approve = tokio::task::spawn(approve_tx_hash_signature_2(&ledger_testing));
| ----------------------------^^^^^^^^^^^^^^^-
| | |
| | borrowed value does not live long enough
| argument requires that `ledger_testing` is borrowed for `'static`
...
215 | }
| - `ledger_testing` dropped here while still borrowed
|
closing this for now. we have the associated issue in the backlog in case we want to pick it up again in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
[TODO: Short statement about what is changing.]
Why
[TODO: Why this change is being made. Include any context required to understand the why.]
Known limitations
[TODO or N/A]