Track SCP latencies in milliseconds for overlay survey #4334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboston7
commented
May 29, 2024
bboston7
commented
May 29, 2024
marta-lokhova
requested changes
May 29, 2024
Fixes stellar#4333 by recording SCP latencies in milliseconds rather than nanoseconds, which could overflow when placed in a `uint32_t`. I also checked the other survey data fields for potential overflow and didn't find anything else that could overflow. However, in doing so I noticed that I failed to bump `TIME_SLICED_SURVEY_MIN_OVERLAY_PROTOCOL_VERSION` to `34` when I bumped the overlay protocol version, so I fixed that as well.
|
r+ 24f4745 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4333 by recording SCP latencies in milliseconds rather than nanoseconds, which could overflow when placed in a
uint32_t.I also checked the other survey data fields for potential overflow and didn't find anything else that could overflow. However, in doing so I noticed that I failed to bump
TIME_SLICED_SURVEY_MIN_OVERLAY_PROTOCOL_VERSIONto34when I bumped the overlay protocol version, so I fixed that as well.Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)