postgresql backend deprecation warning #4348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasBrady
force-pushed
the
deprecate-postgresql-db-backend
branch
from
32145ac
to
1a85f6f
Compare
ThomasBrady
force-pushed
the
deprecate-postgresql-db-backend
branch
from
1a85f6f
to
91d3468
Compare
src/main/Config.cpp
Outdated
| @@ -1433,6 +1433,17 @@ Config::processConfig(std::shared_ptr<cpptoml::table> t) | |||
| else if (item.first == "DATABASE") | |||
| { | |||
| DATABASE = SecretValue{readString(item)}; | |||
| auto connectString = DATABASE.value; | |||
There was a problem hiding this comment.
You can use Database::isSqlite condition to avoid re-implementing string search. The warning should probably clarify that future versions of core will only support BucketListDB for ledger state with SQLite for misc data, with all other backends deprecated.
ThomasBrady
force-pushed
the
deprecate-postgresql-db-backend
branch
from
91d3468
to
484c2a5
Compare
ThomasBrady
force-pushed
the
deprecate-postgresql-db-backend
branch
from
484c2a5
to
0a5dd88
Compare
|
r+ 0a5dd88 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #X
Example output:
config.cfg:
output:
Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)