-
Notifications
You must be signed in to change notification settings - Fork 970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move to "StellarKey" instead of base58 #619
Conversation
ac0f025
to
8eb3897
Compare
As I am staring at the additional changes to move the other database entries that are in hex to base64, it seems weird to me that we would use base64 for the various hashes that we use in the system (hashes are stored also in history in hex form - so we would have to convert those as well). |
8eb3897
to
2cf9db4
Compare
Avoid relying on multiple implementations of the same thing.
bc842fd
to
fb1a84f
Compare
move to "StellarKey" instead of base58 Reviewed-by: jedmccaleb
Move to a new format for keys - resolves #599
This also resolves #273 (faster & simpler encoding all around)
Also resolves #623 : the entries in the database and http endpoint are consistently encoded.
XDR objects: stored in base64
Hashes: Hex
AccountIDs: strKey.
note: this is a breaking change for both Horizon (sql schema updated) and for the config files.
I added a command line to help update the configurations:
also