Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to "StellarKey" instead of base58 #619

Merged
merged 15 commits into from
Jul 17, 2015

Conversation

MonsieurNicolas
Copy link
Contributor

Move to a new format for keys - resolves #599
This also resolves #273 (faster & simpler encoding all around)

Also resolves #623 : the entries in the database and http endpoint are consistently encoded.
XDR objects: stored in base64
Hashes: Hex
AccountIDs: strKey.

note: this is a breaking change for both Horizon (sql schema updated) and for the config files.

I added a command line to help update the configurations:

stellar-core --convertid sfmYZRUn4ofZHzitXupxrrz5QJ7b9mij3rSEdrTNRFVvVgigrcS
Seed:
  strKey: SBI3CZU7XZEWVXU7OZLW5MMUQAP334JFOPXSLTPOH43IRTEQ2QYXU5RG
  base58: sfmYZRUn4ofZHzitXupxrrz5QJ7b9mij3rSEdrTNRFVvVgigrcS
PublicKey:
  strKey: GBA2JPGFUUQ6N4L23K6MUEROQSYMG5BQB3GSFP3KRAXSVGBW7JSV76YL
  base58: gVumxvHdno7nKwNZGK8Bf5bvHrfSNdn8XQ4gdKTXbUXcVax6xE
  hex: 41a4bcc5a521e6f17adabcca122e84b0c374300ecd22bf6a882f2a9836fa655f

also

@MonsieurNicolas MonsieurNicolas changed the title move to "StellarKey instead of base58 move to "StellarKey" instead of base58 Jul 14, 2015
@MonsieurNicolas MonsieurNicolas force-pushed the strKeyEncoding branch 4 times, most recently from ac0f025 to 8eb3897 Compare July 16, 2015 03:55
@MonsieurNicolas
Copy link
Contributor Author

As I am staring at the additional changes to move the other database entries that are in hex to base64, it seems weird to me that we would use base64 for the various hashes that we use in the system (hashes are stored also in history in hex form - so we would have to convert those as well).
Maybe I am just used to it, but I kinda like being able to by just staring at a hash in hex match it to a in memory object, also the abbreviated version looks awfully like what git does.

latobarita added a commit that referenced this pull request Jul 17, 2015
move to "StellarKey" instead of base58

Reviewed-by: jedmccaleb
@latobarita latobarita merged commit fb1a84f into stellar:master Jul 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment