Consolidates model contracts #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpanta94
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This consolidates the model contracts that exist. The factory contract was already removed in #25, so this continues the work. This does a few pieces of work:
First, it removes the
ModelBuildsFromDatainterface because it was, well, pointless. Hahah! TheModelinterface was already extending it, so there's no BC concern here.Second,
ModelReadOnlywas also removed because it's a bit of a misnomer. What it really does it allow for the model to be queried but not saved; the model object is still writable. As a note, it would be cool to add "read only" as a property definition feature.Third, it renames
ModelCRUDtoModelPersistableto make it more readable also clearer what it's purpose is.