Skip to content

Feat/repo set up #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 52 commits into
base: main
Choose a base branch
from
Open

Feat/repo set up #1

wants to merge 52 commits into from
+2,852 −21

Conversation

dpanta94
Copy link
Member

@dpanta94 dpanta94 commented Sep 24, 2025 •
edited
Loading

Introduces the SchemaModel Abstract and interface and also tests.

@dpanta94 dpanta94 self-assigned this Sep 24, 2025
@dpanta94 dpanta94 added the enhancement New feature or request label Sep 24, 2025
@dpanta94
Copy link
Member Author

dpanta94 commented Oct 2, 2025

@JasonTheAdams regarding the Standards, im really against fixing code by hand... The project is including and enforcing the stellarwp/coding-standards (with some overwrites). I think that's where we should be using the PHP-CS-Fixer which supports PER 2.0 and then projects requiring those standards benefiting by them

@dpanta94 dpanta94 requested a review from JasonTheAdams October 2, 2025 14:02
lucatume
lucatume requested changes Oct 2, 2025
View reviewed changes
Copy link

@lucatume lucatume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the work, but think the exception extension would make working with the library easier.

@dpanta94 dpanta94 requested a review from lucatume October 2, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucatume lucatume lucatume approved these changes

@borkweb borkweb Awaiting requested review from borkweb

@JasonTheAdams JasonTheAdams Awaiting requested review from JasonTheAdams

Assignees

@dpanta94 dpanta94

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dpanta94 @borkweb @JasonTheAdams @lucatume