Feature: add methods for replacing and prepending rules #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borkweb
reviewed
Mar 28, 2023
|
Other than that one comment that applies to |
borkweb
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently it's only possible to append validation rules and remove rules. In GiveWP we have a scenario where we want to prepend a
ExcludeUnlessrule to a given ruleset. Actually, we want to replace the rule if it already exists and prepend if it doesn't.This led me to add some useful functions for prepending and replacing rules within a
ValidationRuleSet:prependRulereplaceRule— replaces a rule with a given ID at the same position in the rule setreplaceOrAppendRulereplaceOrPrependRuleThe last two, of course, are just to be declarative and helpful.