remove necessity for specifying empty post in flow

Fix yeoman#249 and yeoman#442
stephanebachelier · Apr 13, 2015 · b96d3c7 · b96d3c7
1 parent d6ed1d2
commit b96d3c7
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 7 deletions.
diff --git a/lib/flow.js b/lib/flow.js
@@ -45,7 +45,7 @@ Flow.prototype.post = function (blockType) {
 //
 Flow.prototype.setPost = function (post) {
   // FIXME: Check format !!!
-  this._post = post;
+  this._post = post || {};
 };
 
 

diff --git a/test/test-flow.js b/test/test-flow.js
@@ -85,4 +85,17 @@ describe('ConfigWriter', function () {
     assert.deepEqual(flow.post('js'), ['foo', 'bar']);
   });
 
+  it('should default to empty post', function () {
+    // default flow
+    var flow = new Flow({
+      steps: {
+        js: ['concat', 'uglify'],
+        css: ['concat', 'cssmin']
+      },
+      post: {}
+    });
+    // this might be called if someone define a flow without adding a `post` entry
+    flow.setPost();
+    assert.deepEqual(flow._post, {});
+  });
 });
diff --git a/test/test-usemin-prepare.js b/test/test-usemin-prepare.js
@@ -225,8 +225,7 @@ describe('useminPrepare', function () {
         flow: {
           steps: {
             js: ['uglify']
-          },
-          post: {}
+          }
         }
       }
     });
@@ -257,8 +256,7 @@ describe('useminPrepare', function () {
           html: {
             steps: {
               js: ['uglify']
-            },
-            post: {}
+            }
           }
         }
       }
@@ -302,8 +300,7 @@ describe('useminPrepare', function () {
         flow: {
           steps: {
             js: [copy]
-          },
-          post: {}
+          }
         }
       }
     });