Skip to content

Conversation

leonardo2204
Copy link
Contributor

@leonardo2204 leonardo2204 commented Jan 11, 2017

I created this PR to address #32 enhancement.
My previous code from the #37 is also here, so, sorry for the long commit.
I'd suggest taking a look at 2c33eaf for code only of the #32 issue.
I managed the issue addressed by @zawadz88 :

When we go to the previous step? If so, when we then go back to the failed step the regular state should be shown instead of the error state?

Adding a showErrorStateOnBack flag, so the user can choose whether or not to clean the error from the current step when moving back.

The main point I'd like to discuss is when we get an error on "complete" state, do all the necessary steps to get it right and press "complete" again. Currently the callback is correctly fired, but the "error" state is never cleared. Not sure if this should be treated, as most of the cases the user will move forward to another screen.

What are your thoughts on that ?

Thanks!

@zawadz88
Copy link
Contributor

Hi @leonardo2204,
Could you rebase these changes on top of the current version of master branch as the 'Further abstraction' code has been already merged? It's currently kind of hard to read the changes ;)

@leonardo2204
Copy link
Contributor Author

@zawadz88 Just did, but I think the changelog will continue.. Should I open another PR ?

@zawadz88
Copy link
Contributor

Yee please :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants