Allow a user to have more than one OcppTag (#1766) #1777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @juherr do you have any suggestions/remarks to improve from your backport? |
|
@goekay None, except maybe those mentioned in the AI review remarks. |
cherrypicking from juherr#33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
Previously, it was possible for multiple users to share one Ocpp Tag. I cannot remember why we/I decided to allow this (if this was an active decision at all). I presume this is not a common usecase. This PR removes that. See V1_0_8__update.sql. Afterwards, an Ocpp Tag can belong only to one user. And a user can have multiple Ocpp Tags.
User overview after PR: