Replaced jQuery with $ to work with UMD wrapper #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UMD wrapper for ko.plus library exposes jQuery as $ for the parts. But for sortable part jQuery is still passed into the IIFE which makes it look globally for jQuery variable instead of using parameter $. This pull request addresses that, (but if sortable is used as a separate file and $ is not set on window then might break).
|
Thanks! Would it be possible to update the npm package? |
|
All done - 0.0.32 is up now. Enjoy!
…On Mon, 16 Jul 2018 at 09:52, SimmeNilsson ***@***.***> wrote:
Thanks! Would it be possible to update the npm package?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#27 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA0J0OMW7buu_LYR_qzhq3cEIj-ydUC5ks5uHFRLgaJpZM4U5rlI>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UMD wrapper for ko.plus library exposes jQuery as $ for the parts.
But for sortable part jQuery is still passed into the IIFE which makes it look globally for jQuery variable instead of using parameter $.
This pull request addresses that, (but if sortable is used as a separate file and $ is not set on window then might break).