Quality of life: Improve keyboard selection to first restrict to node… #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lakbychance is attempting to deploy a commit to the Elegance Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Wow I LOVE this! Incredible attention to detail – thank you so much for the PR! |
|
Found a super weird bug – it looks like when the whole document is selected, it inherits the hyperlink from the link at the start of the document: CleanShot.2023-09-04.at.16.00.20.mp4 |
|
Ok looks like it's not specific to this PR but a bug in Novel's implementation: CleanShot.2023-09-04.at.16.03.10.mp4Will merge this now but open a separate issue for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at achieving Notion-style selection where pressing Mod+a first selects only the content within the node's boundary and pressing Mod+a again selects the whole content.
Screen.Recording.2023-09-03.at.6.18.30.PM.mov