Fix default scopes for KC20 #56
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance this gets merged and a new release? Best regards |
|
@micbis I will look at Wednesday night |
|
Hi @mstefan21 Great, thanks for checking. Best regards |
|
@micbis please fix code with coding-styles and errors from failed checks and rebase on last commit. thank you |
|
Hi @mstefan21 The pull request was already based on the last commit. I also fixed the code style error, which was unrelated to this change. Best regards |
|
Is there anything else we can help with? It would be great if this could be merged. Best regards |
|
@micbis I am working now on release of new version. I made your changes in my branch with implementing your idea with add version. |
|
Released as new version 3.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on issue #55, added the required scope openid to the default list.