Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include *.js.tt files in bundled gem #273

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Conversation

marcoroth
Copy link
Member

Type of PR

Bug fix

Description

All template files for the installer (*.js.tt) were missing in the bundled gem. This pull requests adds the *.tt ending to the files config inside the gemspec.

Why should this be added

So the installer works properly again. The installer was failing with:

--- [esbuild] ----
rails aborted!
Thor::Error: Could not find "/3.2.0/gems/cable_ready-5.0.0.rc2/lib/generators/cable_ready/templates/esbuild.config.mjs.tt" in any of your source paths. Your current source paths are:
/3.2.0/lib/ruby/gems/3.2.0/gems/railties-7.0.4.3/lib/rails/generators/rails/app/templates

Tasks: TOP => app:template
(See full trace by running task with --trace)

--- [config] ----
rails aborted!
Thor::Error: Could not find "/3.2.0/gems/cable_ready-5.0.0.rc2/lib/generators/cable_ready/templates/app/javascript/config/index.js.tt" in any of your source paths. Your current source paths are:
/3.2.0/gems/railties-7.0.4.3/lib/rails/generators/rails/app/templates

Checklist

  • My code follows the style guidelines of this project
  • Checks (StandardRB & Prettier-Standard) are passing

@netlify
Copy link

netlify bot commented Mar 30, 2023

Deploy Preview for cableready ready!

Name Link
🔨 Latest commit 3665305
🔍 Latest deploy log https://app.netlify.com/sites/cableready/deploys/6425b8867ba2f80008025d85
😎 Deploy Preview https://deploy-preview-273--cableready.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@marcoroth marcoroth merged commit 5f76b72 into main Mar 31, 2023
@marcoroth marcoroth deleted the include-tt-files-in-gem branch March 31, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants