Add trigger and target element logs for devtools #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cableready ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
hopsoft
requested changes
Jun 8, 2023
| @@ -32,6 +32,9 @@ export default class UpdatesForElement extends SubscribingElement { | |||
| super() | |||
| const shadowRoot = this.attachShadow({ mode: 'open' }) | |||
| shadowRoot.innerHTML = template | |||
|
|
|||
| this.triggerElementLog = [] | |||
| this.targetElementLog = [] | |||
There was a problem hiding this comment.
Do we need to clear these logs or perhaps have a log stack that we move them to when cable-ready:after-update is dispatched?
There was a problem hiding this comment.
🤔
You are probably correct, though in my tests it didn't really matter because they are cleared with every browser refresh.
I think the easiest would be to limit them to a small number (10?) and do a kind of FIFO thing so they get cleared automatically?
There was a problem hiding this comment.
I added a BoundedQueue class, let me know if you like the implementation.
Also, added datetime strings to the log lines
hopsoft
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement
Description
Furnishes cable-ready-updates-for-element with instance variables for element logs, so they can displayed in the devtools like this: