Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow open drain timer pin #133

Merged
merged 1 commit into from
Jan 20, 2023
Merged

Allow open drain timer pin #133

merged 1 commit into from
Jan 20, 2023

Conversation

andrej-mk
Copy link
Contributor

I2C SDA and SCL pins use similar approach - they accept Output<OpenDrain> and then set alternate function mode.

  • remove generic MODE parameter from macro invocations
  • generate TimerPin trait impl for Analog and Output<OpenDrain> modes

@andrej-mk andrej-mk changed the title Allow open drain timer pin(#132) Allow open drain timer pin Jan 8, 2023
@andrej-mk andrej-mk mentioned this pull request Jan 8, 2023
Closed
@andresv
Copy link
Member

andresv commented Jan 20, 2023

Could you fix formatting with cargo fmt.

@andrej-mk
Copy link
Contributor Author

Done. I've run cargo fmt.

@dotcypress
Copy link
Member

Thank you @andrej-mk!

@dotcypress dotcypress merged commit 6d262e1 into stm32-rs:main Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotcypress dotcypress dotcypress approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrej-mk @andresv @dotcypress