Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allows arduino-cli to override build property #1725

Merged
merged 1 commit into from
May 25, 2022

Conversation

fpistm
Copy link
Member

@fpistm fpistm commented May 23, 2022

Arduino-cli allows to override some standard Arduino build property with a custom value.
Previously some of them was already used in boards.txt/platform.txt preventing to use it.

This PR remove this usage by defining some custom properties making the default one empty and usable by end user.
build.extra_flags, compiler.c.extra_flags and compiler.S.extra_flags can now be redefined all other were already empty by default.

Fixes #1709

Fixes stm32duino#1709

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Copy link
Contributor

@ABOSTM ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

STM32 core based on ST HAL automation moved this from In progress to Reviewer approved May 23, 2022
@fpistm fpistm merged commit 7693658 into stm32duino:main May 25, 2022
STM32 core based on ST HAL automation moved this from Reviewer approved to Done May 25, 2022
@fpistm fpistm deleted the extra_flags branch May 25, 2022 16:29
@ABOSTM ABOSTM mentioned this pull request Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Arduino CLI fails to build when parameter --build-property build.extra_flags=-Werror is specified
2 participants