Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added STM32F765IIKx #1732

Merged
merged 7 commits into from
Jun 2, 2022
Merged

Added STM32F765IIKx #1732

merged 7 commits into from
Jun 2, 2022

Conversation

PumaFPV
Copy link
Contributor

@PumaFPV PumaFPV commented May 30, 2022

Summary

Adds STM32F765IIKx
Another PR will be done to add the JSON on according repo.

I had to use a board that had a F765 on it, it could be usefull for someone else.

@PumaFPV
Copy link
Contributor Author

PumaFPV commented May 30, 2022

Generic board JSON has been PR here platformio/platform-ststm32#629 I dont know how to do it on these ST repo

@fpistm fpistm requested a review from ABOSTM May 31, 2022 06:36
@fpistm fpistm added this to In progress in STM32 core based on ST HAL via automation May 31, 2022
@fpistm fpistm added this to the 2.3.0 milestone May 31, 2022
Copy link
Contributor

@ABOSTM ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PumaFPV ,
Thanks for this Pull Request.
See inline comments

STM32 core based on ST HAL automation moved this from In progress to Needs review May 31, 2022
Copy link
Contributor

@ABOSTM ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PumaFPV
LGTM

STM32 core based on ST HAL automation moved this from Needs review to Reviewer approved Jun 1, 2022
STM32 core based on ST HAL automation moved this from Reviewer approved to Needs review Jun 1, 2022
STM32 core based on ST HAL automation moved this from Needs review to Reviewer approved Jun 1, 2022
boards.txt Outdated Show resolved Hide resolved
STM32 core based on ST HAL automation moved this from Reviewer approved to Needs review Jun 1, 2022
also, add all other mcu entries available and reference
them in the README.

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
Copy link
Member

fpistm commented Jun 2, 2022

I've deeply reviewed this PR as it does not build and saw the boards.txt was not correct.
So, I've fixed it and added similar mcu entries (referenced them in the README.md)
I've also update the clock config to have a 48MHz clock for USB and SDMMC.

STM32 core based on ST HAL automation moved this from Needs review to Reviewer approved Jun 2, 2022
@fpistm fpistm merged commit 1a2c5e9 into stm32duino:main Jun 2, 2022
STM32 core based on ST HAL automation moved this from Reviewer approved to Done Jun 2, 2022
cparata pushed a commit to cparata/Arduino_Core_STM32 that referenced this pull request Jan 31, 2023
…uino#1732)


Co-authored-by: Frederic Pillon <frederic.pillon@st.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants