Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review get adc/dac/timer channel functions #1735

Merged
merged 5 commits into from
Jun 8, 2022
Merged

Review get adc/dac/timer channel functions #1735

merged 5 commits into from
Jun 8, 2022

Conversation

fpistm
Copy link
Member

@fpistm fpistm commented Jun 3, 2022

This PR exports some getter api:

uint32_t get_adc_channel(PinName pin, uint32_t *bank);
uint32_t get_adc_internal_channel(PinName pin);
uint32_t get_dac_channel(PinName pin);

Fixes #1669

@fpistm fpistm added this to the 2.3.0 milestone Jun 3, 2022
@fpistm fpistm requested a review from ABOSTM June 3, 2022 15:46
@fpistm fpistm added this to In progress in STM32 core based on ST HAL via automation Jun 3, 2022
@fpistm fpistm marked this pull request as draft June 3, 2022 16:33
@fpistm fpistm marked this pull request as ready for review June 8, 2022 09:03
ABOSTM
ABOSTM reviewed Jun 8, 2022
View reviewed changes
Copy link
Contributor

@ABOSTM ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment otherwise LGTM

cores/arduino/stm32/analog.h Show resolved Hide resolved
@fpistm
refactor(analog): move get_pwm_channel to timer api
76aed2b 
Moved from analog.* to timer.*.

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
refactor(timer): rename channel function
449b721 
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
feat(analog): export adc/dac get channel functions
98b73ab 
Fixes stm32duino#1669

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
refactor: harden analog and timer get channel functions
14ba203 
as 0 can be a valid value.

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
fix(analog): guard some declarations
f731fdb 
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
STM32 core based on ST HAL automation moved this from In progress to Reviewer approved Jun 8, 2022
@fpistm fpistm merged commit b715820 into stm32duino:main Jun 8, 2022
STM32 core based on ST HAL automation moved this from Reviewer approved to Done Jun 8, 2022
@fpistm fpistm deleted the review_channel_function branch June 8, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ABOSTM ABOSTM ABOSTM approved these changes

Assignees
No one assigned
Labels
Enhancement Fix
Projects
STM32 core based on ST HAL
  
Done
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

Exposing get_adc_channel function
2 participants
@fpistm @ABOSTM