Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Enable Swan CDCgen by default #1797

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

zfields
Copy link
Contributor

@zfields zfields commented Aug 11, 2022

To make it easier for Swan users, we have decided to enable CDC (generic 'Serial' supersede U(S)ART) by default. If customers wish to remove USB support to optimize their binary, they may deselect it from the menu.

Pull Request template

Please, Make sure that your PR is not a duplicate.
Search among the Pull request before creating one.

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.

Thanks for submitting a pull request.
Please provide enough information so that others can review your pull request:

Summary

This PR fixes/implements the following bugs/features

  • Bug 1
  • Bug 2
  • Feature 1
  • Feature 2
  • Breaking changes

Explain the motivation for making this change. What existing problem does the pull request solve?

Validation

  • Ensure CI build is passed.
  • Demonstrate the code is solid. [e.g. Provide a sketch]

Code formatting

  • Ensure AStyle check is passed thanks CI

Closing issues

Fixes #xxx

To make it easier for Swan users, we have decided to enable `CDC (generic 'Serial' supersede U(S)ART)` by default. If customers wish to remove USB support to optimize their binary, they may deselect it from the menu.
Copy link
Contributor

@ABOSTM ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fpistm fpistm added this to the 2.4.0 milestone Aug 22, 2022
@fpistm fpistm added this to In progress in STM32 core based on ST HAL via automation Aug 22, 2022
@fpistm fpistm merged commit ffeebe7 into stm32duino:main Aug 22, 2022
STM32 core based on ST HAL automation moved this from In progress to Done Aug 22, 2022
@zfields zfields deleted the blues-swan-default branch August 24, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants