Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SparkFun MicroMod STM32F405 #1987

Merged
merged 23 commits into from
Mar 31, 2023
Merged

Add SparkFun MicroMod STM32F405 #1987

merged 23 commits into from
Mar 31, 2023

Conversation

bsatrom
Copy link
Contributor

@bsatrom bsatrom commented Mar 29, 2023

Summary

Add support for the SparkFun MicroMod STM32F405

Validation

Tested locally with the CheckVariant sketch.

@bsatrom bsatrom mentioned this pull request Mar 29, 2023
Merged
@fpistm fpistm self-requested a review March 30, 2023 07:18
@fpistm fpistm added this to In progress in STM32 core based on ST HAL via automation Mar 30, 2023
fpistm
fpistm requested changes Mar 30, 2023
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bsatrom
thanks for your contribution.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
boards.txt Outdated Show resolved Hide resolved
variants/STM32F4xx/F405RGT_F415RGT/variant_MICROMOD_F405.h Outdated Show resolved Hide resolved
STM32 core based on ST HAL automation moved this from In progress to Needs review Mar 30, 2023
bsatrom and others added 2 commits March 30, 2023 08:27
@bsatrom @fpistm
Update README.md
eb3a7c8 
Co-authored-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Brandon Satrom <bsatrom+gh@gmail.com>
@bsatrom @fpistm
Update variants/STM32F4xx/F405RGT_F415RGT/variant_MICROMOD_F405.h
85232db 
Co-authored-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Brandon Satrom <bsatrom+gh@gmail.com>
@fpistm fpistm added this to the 2.6.0 milestone Mar 30, 2023
@bsatrom bsatrom requested a review from fpistm March 30, 2023 13:58
fpistm
fpistm requested changes Mar 30, 2023
View reviewed changes
CI/build/conf/cores_config.json Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
boards.txt Outdated Show resolved Hide resolved
boards.txt Outdated Show resolved Hide resolved
boards.txt Outdated Show resolved Hide resolved
boards.txt Outdated Show resolved Hide resolved
variants/STM32F4xx/F405RGT_F415RGT/PeripheralPins_MICROMOD_F405.c Show resolved Hide resolved
variants/STM32F4xx/F405RGT_F415RGT/variant_MICROMOD_F405.h Outdated Show resolved Hide resolved
variants/STM32F4xx/F405RGT_F415RGT/variant_MICROMOD_F405.h Outdated Show resolved Hide resolved
bsatrom and others added 9 commits March 30, 2023 09:29
@bsatrom @fpistm
Update boards.txt
eb29528 
Co-authored-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Brandon Satrom <bsatrom+gh@gmail.com>
@bsatrom @fpistm
Update boards.txt
4353450 
Co-authored-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Brandon Satrom <bsatrom+gh@gmail.com>
@bsatrom @fpistm
Update boards.txt
e917216 
Co-authored-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Brandon Satrom <bsatrom+gh@gmail.com>
@bsatrom @fpistm
Update boards.txt
85d17a6 
Co-authored-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Brandon Satrom <bsatrom+gh@gmail.com>
@bsatrom @fpistm
Update variants/STM32F4xx/F405RGT_F415RGT/variant_MICROMOD_F405.h
69594a3 
Co-authored-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Brandon Satrom <bsatrom+gh@gmail.com>
@bsatrom @fpistm
Update variants/STM32F4xx/F405RGT_F415RGT/variant_MICROMOD_F405.h
340c11b 
Co-authored-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Brandon Satrom <bsatrom+gh@gmail.com>
@bsatrom
add empty line back to README
7da1da8
@bsatrom
add empty line back to README
ca0877e
@bsatrom
update PerhiperalPins based on updated generic base
adad150
@bsatrom bsatrom requested a review from fpistm March 30, 2023 14:46
fpistm
fpistm requested changes Mar 30, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@bsatrom bsatrom requested a review from fpistm March 30, 2023 17:15
fpistm
fpistm requested changes Mar 31, 2023
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After those required changes, I think it would be ok to merge.

variants/STM32F4xx/F405RGT_F415RGT/variant_MICROMOD_F405.h Outdated Show resolved Hide resolved
boards.txt Show resolved Hide resolved
cmake/boards_db.cmake Show resolved Hide resolved
bsatrom and others added 3 commits March 31, 2023 08:53
@bsatrom @fpistm
Update variants/STM32F4xx/F405RGT_F415RGT/variant_MICROMOD_F405.h
9af771f 
Co-authored-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Brandon Satrom <bsatrom+gh@gmail.com>
@bsatrom @fpistm
Update boards.txt
d72d0f1 
Co-authored-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Brandon Satrom <bsatrom+gh@gmail.com>
@bsatrom
update cmake files via cmake_updater_hook.py
761c4d1
@bsatrom
Copy link
Contributor Author

bsatrom commented Mar 31, 2023

After those required changes, I think it would be ok to merge.

All done, thanks for being so quick to review @fpistm!

STM32 core based on ST HAL automation moved this from Needs review to Reviewer approved Mar 31, 2023
@fpistm
Copy link
Member

fpistm commented Mar 31, 2023

Welcome @bsatrom
Thanks for the quick update too 😉
LGTM, waiting CI status before merge. Of course I did not test the board as I do not have it.

@fpistm fpistm merged commit 2d21caa into stm32duino:main Mar 31, 2023
STM32 core based on ST HAL automation moved this from Reviewer approved to Done Mar 31, 2023
@bsatrom bsatrom deleted the sparkfun-micromod-f405 branch March 31, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpistm fpistm fpistm approved these changes

Assignees
No one assigned
Labels
New variant
Projects
STM32 core based on ST HAL
  
Done
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bsatrom @fpistm