Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PlatformIO build script #2135

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Update PlatformIO build script #2135

merged 1 commit into from
Sep 21, 2023

Conversation

valeros
Copy link
Contributor

@valeros valeros commented Sep 20, 2023

This PR updates PlatformIO build script according to the latest changes in the core:

  • Updated build flags
  • Better formatting

@fpistm
Copy link
Member

fpistm commented Sep 20, 2023

Hi @valeros
Thanks for the PR.
Could you rebase on top of the main then the pio CI will be launched.

@fpistm fpistm added this to the 2.7.0 milestone Sep 20, 2023
@fpistm fpistm added this to In progress in STM32 core based on ST HAL via automation Sep 20, 2023
@fpistm fpistm self-requested a review September 21, 2023 08:03
@fpistm fpistm mentioned this pull request Sep 21, 2023
Closed
2 tasks
@valeros @fpistm
Update platformio-build.py
bc54f33 
Signed-off-by: Valerii Koval <valeros@users.noreply.github.com>
@fpistm
Copy link
Member

fpistm commented Sep 21, 2023

Hi @valeros
I've rebased and revert commit which disabled the pio build.
I've added the cmsis_dsp to the list of ignored library, as it always use the CMSIS 5.7.0 eve if the 5.9.0 is defined as default version.

@fpistm fpistm merged commit 1ee0a03 into stm32duino:main Sep 21, 2023
3 checks passed
STM32 core based on ST HAL automation moved this from In progress to Done Sep 21, 2023
@valeros valeros deleted the patch-1 branch September 21, 2023 08:44
thijses added a commit to thijses/STM32WB55_custom_arduino_bootloader that referenced this pull request Sep 22, 2023
@thijses
fixes/improvements
4d4336a 
- fixed uploader offset (i just wrote a bad python scipt (forgot flash_base, and it must be hex()))
- fixed platformio-build.py dependency (by using the newest stm32duino core version, which includes fixes). See stm32duino/Arduino_Core_STM32#2135
- cleaned up some minor stuff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpistm fpistm Awaiting requested review from fpistm

Assignees
No one assigned
Labels
Enhancement Fix
Projects
STM32 core based on ST HAL
  
Done
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@valeros @fpistm