Remove atomicity warning that does not apply to STM32 #2502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Taylor Braun-Jones <taylor@braun-jones.org>
fpistm
requested changes
Aug 28, 2024
There was a problem hiding this comment.
Hi @nocnokneo
Thanks for thePR.
You're right this warning could be removed it is an artifact when the class was created using original Arduino Class.
Signed-off-by: Taylor Braun-Jones <taylor@braun-jones.org>
fpistm
approved these changes
Aug 28, 2024
fpistm
added
fix 🩹
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes an atomicity warning in
HardwareSerial.hthat does not apply to (32-bit) STM32. Based on a review on this response and my own testing, I'm convinced that the atomicity warning and link to an ArduinoCore-avr issue is not relevant.