Skip to content

Fix weaked serialEventRun() not being called #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2020
Merged

Fix weaked serialEventRun() not being called #987

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cores/arduino/WSerial.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#include "WSerial.h"

void serialEventRun(void)
WEAK void serialEventRun(void)
{
#if defined(HAVE_HWSERIAL1)
if (serialEvent1 && Serial1.available()) {
Expand Down
2 changes: 1 addition & 1 deletion cores/arduino/WSerial.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,6 @@ extern void serialEvent10(void) __attribute__((weak));
extern void serialEventLP1(void) __attribute__((weak));
#endif /* HAL_UART_MODULE_ENABLED && !HAL_UART_MODULE_ONLY */

extern void serialEventRun(void) __attribute__((weak));
extern void serialEventRun(void);

#endif /* WIRING_SERIAL_H */
4 changes: 1 addition & 3 deletions cores/arduino/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,7 @@ int main(void)
CoreCallback();
#endif
loop();
if (serialEventRun) {
serialEventRun();
}
serialEventRun();
}

return 0;
Expand Down