Skip to content

Add support for subSeconds alarms #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 27, 2020
Merged

Add support for subSeconds alarms #25

merged 6 commits into from
May 27, 2020

Conversation

angelnu
Copy link
Contributor

@angelnu angelnu commented May 23, 2020 •
edited
Loading

I need to use this to add support to ms sleeps in the STM32LowPower library. This addresses #25

@angelnu angelnu mentioned this pull request May 24, 2020
Closed
@fpistm
Copy link
Member

fpistm commented May 26, 2020

Hi @angelnu
I guess you would mean it addresses #17 ?

@angelnu
Copy link
Contributor Author

angelnu commented May 26, 2020 •
edited
Loading

actually both... There was already a call to set the subseconds for the RTC so I added the support for it in the alarm.

@fpistm
Copy link
Member

fpistm commented May 26, 2020

Ok you would say #23 from STM32LowPower....
You wrote #25 in your first post...

fpistm
fpistm reviewed May 26, 2020
View reviewed changes
@angelnu
Copy link
Contributor Author

angelnu commented May 26, 2020

I will remove it - please notice that the low-power package would depend on this PR.

@angelnu
Revert "Increase version"
9ba022c 
This reverts commit 51e2338.
@fpistm
Copy link
Member

fpistm commented May 26, 2020

I will remove it - please notice that the low-power package would depend on this PR.

I saw anyway it is the same for STM32 Low Power and I will think about removing dependency....

@angelnu
Copy link
Contributor Author

angelnu commented May 26, 2020

version change removed

@fpistm
Review
3cc7026 
Fix issue with STM32RTC::setAlarmTime
Update some Typo
Update keywords.txt
Update README.md

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm fpistm added the enhancement New feature or request label May 27, 2020
@fpistm fpistm added this to the 1.0.4/1.1.0 milestone May 27, 2020
fpistm
fpistm approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @angelnu

@fpistm fpistm merged commit 0df97f0 into stm32duino:master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpistm fpistm fpistm approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@angelnu @fpistm