Make collections retrieval parallel #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes calls to get the objects from a collection link parallel. Some collections can contain a large number of items to retrieve. Doing this serially can have a noticable performance impact. This change allows three fetches in parallel so we don't overwhelm the Redfish service and cause a denial of service. With three concurrent operations we can be processing some responses while queuing up the more, making it a lot faster to process. Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com> Co-Authored-by: Lorenzo Bolognesi <lorenzo.bolognesi@dxc.com>
This hasn't been very useful, so just disable it. Signed-off-by: Sean McGinnis <stmcg@amazon.com>
stmcginnis
force-pushed
the
pci-async
branch
from
d1531bb
to
95bee86
Compare
stmcginnis
changed the title
|
Been out here long enough. Was hoping for external validation that things are working well, but I'm sure I'll find out soon enough if there are issues. ;) |
feuerrot
pushed a commit
to babiel/gofish
that referenced
this pull request
May 24, 2023
* Make collection retrievals parallel This makes calls to get the objects from a collection link parallel. Some collections can contain a large number of items to retrieve. Doing this serially can have a noticable performance impact. This change allows three fetches in parallel so we don't overwhelm the Redfish service and cause a denial of service. With three concurrent operations we can be processing some responses while queuing up the more, making it a lot faster to process. Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com> Co-Authored-by: Lorenzo Bolognesi <lorenzo.bolognesi@dxc.com> * Disable gomnd linter This hasn't been very useful, so just disable it. Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com> Co-authored-by: Lorenzo Bolognesi <lorenzo.bolognesi@dxc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes calls to get the objects from a collection link parallel.
Some collections can contain a large number of items to retrieve. Doing this serially can have a noticable performance impact. This change allows three fetches in parallel so we don't overwhelm the Redfish service and cause a denial of service. With three concurrent operations we can be processing some responses while queuing up the more, making it a lot faster to process.