Skip to content

Conversation

jnpacker
Copy link
Member

…int the python code

FYI the type.go tests are not working, but I'm not sure how useful building a CRD from them will be since they import references from other projects, so the CRD available in the current _type.go is just a subset of the objects that make it up.

Using the generated CRD Yaml is a much better approach.

…int the python code

Signed-off-by: Joshua Packer <jpacker@redhat.com>
Signed-off-by: Joshua Packer <jpacker@redhat.com>
@jnpacker
Copy link
Member Author

/assign @bjoydeep @qiujian16

@qiujian16
Copy link
Collaborator

Using the generated CRD Yaml is a much better approach.
I agree, or if we have a crd template we can run helm to render it?

@qiujian16
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 27, 2025
Copy link

openshift-ci bot commented Jun 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jnpacker, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9c52345 into stolostron:main Jun 27, 2025
3 checks passed
@jnpacker jnpacker deleted the acm-21772 branch June 27, 2025 12:30
@jnpacker
Copy link
Member Author

We don't have a definition where actual values are rendered by HELM variables, but we do have some Helm charts in pieces like VolSync where there are IF statements on whether to provision the CRD, that the code now ignores.

If we get to a point where we have an actual CRD rendered with Variables from Helm, we can add some code, but I suspect in that case we might just make sure there is a Makefile target, and call that before we call make gen-api-docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants