-
-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sql): code refactor for misleading-indentation(#1542) #1646
feat(sql): code refactor for misleading-indentation(#1542) #1646
Conversation
Thanks for the contribution! Please review the labels and make any necessary changes. |
These code causes unpredictable behavior? |
e62d6fa
to
bd5553f
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## stonedb-5.7-dev #1646 +/- ##
====================================================
+ Coverage 0 55.20% +55.20%
====================================================
Files 0 2031 +2031
Lines 0 431427 +431427
====================================================
+ Hits 0 238170 +238170
- Misses 0 193257 +193257
☔ View full report in Codecov by Sentry. |
These changes may cause unexpected behaviour on The cmd is:
Thanks! |
@hustjieke thanks for pointing out. Will take a look soon. |
From the test results, it seems that some of the previous modifications have solved the problem of primary key scanning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Thanks for the contribution! Please review the labels and make any necessary changes. |
Summary about this PR
Issue Number: close #1542
Tests Check List
Changelog
Documentation