Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sql): code refactor for misleading-indentation(#1542) #1646

Conversation

zzzz-vincent
Copy link
Contributor

Summary about this PR

Issue Number: close #1542

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented May 1, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-feature feature for pull request label May 1, 2023
@hustjieke
Copy link
Collaborator

These code causes unpredictable behavior?

@zzzz-vincent zzzz-vincent force-pushed the 1542-rm-useless-code-in-sql-optimizer branch from e62d6fa to bd5553f Compare May 8, 2023 01:08
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch coverage: 83.33% and project coverage change: +55.20 🎉

Comparison is base (a33ba87) 0.00% compared to head (bd5553f) 55.20%.

❗ Current head bd5553f differs from pull request most recent head b0ae8dc. Consider uploading reports for the commit b0ae8dc to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                  @@
##           stonedb-5.7-dev    #1646       +/-   ##
====================================================
+ Coverage                 0   55.20%   +55.20%     
====================================================
  Files                    0     2031     +2031     
  Lines                    0   431427   +431427     
====================================================
+ Hits                     0   238170   +238170     
- Misses                   0   193257   +193257     
Impacted Files Coverage Δ
sql/sql_optimizer.cc 79.24% <83.33%> (ø)

... and 2030 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hustjieke
Copy link
Collaborator

These changes may cause unexpected behaviour on innodb, can you make a regression test on innodb?

The cmd is:

./mysql-test-run.pl --suite=innodb,main --mysqld=--default-storage-engine=innodb --nowarnings --force --nocheck-testcases --retry=0 --do-test-list=./suite/innodb/include/innodb_testlist --parallel=15

Thanks!

@zzzz-vincent
Copy link
Contributor Author

@hustjieke thanks for pointing out. Will take a look soon.

@Nliver Nliver added this to the StoneDB_5.7_v1.0.4 milestone May 9, 2023
@Nliver Nliver requested a review from hustjieke May 9, 2023 02:13
@konghaiya
Copy link
Collaborator

From the test results, it seems that some of the previous modifications have solved the problem of primary key scanning
It should be possible to relax the restrictions on the use of primary keys,

Copy link
Collaborator

@konghaiya konghaiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@RingsC RingsC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@mergify
Copy link
Contributor

mergify bot commented May 9, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot merged commit 8d438e1 into stoneatom:stonedb-5.7-dev May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-feature feature for pull request
Projects
Development

Successfully merging this pull request may close these issues.

feature: rm useless code in sql_optimizer.cc
5 participants