fix(tianmu): Fixup the mem leakage of aggregation function #1867
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary about this PR
1: Fixup the memory leakage of aggregation function, which may lead to failed of malloc.
2: Re-impl the operator= of
ValueOrNull
.3: Fixup the assertion of
dow_cast
inQuery::ClearSubselectTransformation
,Item_func_trig_cond
.Issue Number: close #1855
Tests Check List
Changelog
Documentation