Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tianmu): Fixup the mem leakage of aggregation function #1867

Merged
merged 2 commits into from
Jun 8, 2023
Merged

fix(tianmu): Fixup the mem leakage of aggregation function #1867

merged 2 commits into from
Jun 8, 2023

Conversation

RingsC
Copy link
Contributor

@RingsC RingsC commented Jun 8, 2023

Summary about this PR

1: Fixup the memory leakage of aggregation function, which may lead to failed of malloc.
2: Re-impl the operator= of ValueOrNull.
3: Fixup the assertion of dow_cast in Query::ClearSubselectTransformation, Item_func_trig_cond.

Issue Number: close #1855

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Jun 8, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-bug bug for pull request label Jun 8, 2023
1: Fixup the memory leakage of aggregation function, which may lead to failed of malloc.
2: Re-impl the operator= of `ValueOrNull`.
3: Fixup the assertion of `dow_cast` in ` Query::ClearSubselectTransformation`, `Item_func_trig_cond`.
@RingsC RingsC marked this pull request as ready for review June 8, 2023 11:47
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch coverage: 52.79% and project coverage change: +0.49 🎉

Comparison is base (2579bd4) 54.69% compared to head (2f16849) 55.18%.

❗ Current head 2f16849 differs from pull request most recent head 0ce0c57. Consider uploading reports for the commit 0ce0c57 to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                 @@
##           stonedb-5.7-dev    #1867      +/-   ##
===================================================
+ Coverage            54.69%   55.18%   +0.49%     
===================================================
  Files                 2031     2031              
  Lines               431442   431521      +79     
===================================================
+ Hits                235965   238152    +2187     
+ Misses              195477   193369    -2108     
Impacted Files Coverage Δ
storage/tianmu/common/common_definitions.h 84.21% <ø> (ø)
storage/tianmu/compress/basic_data_filt.cpp 45.03% <0.00%> (ø)
storage/tianmu/compress/data_stream.h 62.90% <ø> (ø)
storage/tianmu/compress/dictionary.h 26.61% <0.00%> (ø)
storage/tianmu/compress/inc_alloc.cpp 26.41% <ø> (ø)
storage/tianmu/compress/inc_alloc.h 6.66% <ø> (ø)
storage/tianmu/compress/inc_wgraph.cpp 2.19% <ø> (ø)
storage/tianmu/compress/inc_wgraph.h 5.88% <ø> (ø)
storage/tianmu/compress/ppm.cpp 0.00% <ø> (ø)
storage/tianmu/compress/suffix_tree.cpp 0.00% <0.00%> (ø)
... and 141 more

... and 146 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@hustjieke hustjieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 6b369e5 into stoneatom:stonedb-5.7-dev Jun 8, 2023
@RingsC RingsC deleted the fix-issue-1855-aggregate-function-out-of-bounds branch June 8, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-bug bug for pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: The instance is crashed if the aggregate function out of bounds
3 participants