fix(walker): reuse allOfs correctly #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey 👋 can I have the status of this? Is it only waiting for @paulatulis or @wmhilton 's review? |
|
Yeah, it's only lacking a review. |
paulatulis
approved these changes
Apr 7, 2021
There was a problem hiding this comment.
I know my lack of understanding around what this all actually does is holding the entire team back, so I am going to go ahead and approve because it looks like the issue is solved by @P0lip's changes. That said, I would feel better if someone else on @stoplightio/void-crew could give it a pass as well. Apologies for the delay!
|
🎉 This PR is included in version 1.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
billiegoose
reviewed
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6
The issue is mostly caused by the fact
json-schema-merge-allofcreates a object, and thereforeprocessedFragmentscheck is missed. This is why I resorted to relying onallOfrather than the whole fragment.allOfitself is stable and not cloned.On a side note - although I haven't measured the perf difference, I suppose we should see some gains in certain situations (such as more than a single $ref to the same allOf).
The current JSV (3.x.x) is also vulnerable to the same issue - it handles it worse than the new version of JSV (v4) will, as the current version just keeps populating the tree until it eventually fails (see the error in the console).
This is how it looks like when yalced in JSV v4.
Rows are collapsible now!