Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/sl 2192/stringify examples #205

Merged
merged 15 commits into from
Apr 2, 2019
Merged

Fix/sl 2192/stringify examples #205

merged 15 commits into from
Apr 2, 2019

Conversation

karol-maciaszek
Copy link
Contributor

@karol-maciaszek karol-maciaszek commented Mar 28, 2019 •
edited
Loading

Issue: https://stoplightio.atlassian.net/browse/SL-2192

The cause of freeze was that fastify received object as a response body instead of string. This PR enforces response body to be stringified.

@karol-maciaszek
fix: SL-2191 repaired mock config switch
0fcdbfd
@karol-maciaszek
chore: SL-2191 separated config from components
6d98b3b
@karol-maciaszek
fix: SL-2191 fixed cli tests
2af3e98
@karol-maciaszek
fix: SL-2191 fixed tests
d3ab8e3
@karol-maciaszek
fix: SL-2191 config as a separate parameter for prism
1e8b1d8
@karol-maciaszek
fix: SL-2191 fixed tests
186e7e9
@karol-maciaszek
fix: SL-2191 removed unneeded merge of defaultConfig
a9517e0
@karol-maciaszek
Merge branch 'develop' into fix/SL-2191/separate-config-concept
212d29c 
# Conflicts:
#	packages/core/src/factory.ts
#	packages/core/src/utils/__tests__/__snapshots__/configMergerFactory.spec.ts.snap
#	packages/core/src/utils/__tests__/configMergerFactory.spec.ts
#	packages/core/src/utils/configMergerFactory.ts
#	packages/core/src/utils/resolveConfig.ts
#	packages/http-server/src/getHttpConfigFromRequest.ts
@karol-maciaszek
fix: SL-2192 forced examples to be stringified
71b330a
XVincentX
XVincentX suggested changes Apr 1, 2019
View reviewed changes
Copy link
Contributor

@XVincentX XVincentX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think we need a new whole fixture; the functional snapshot changes look enough to me.

@karol-maciaszek
Copy link
Contributor Author

I do not think we need a new whole fixture; the functional snapshot changes look enough to me.

  • it’s an fixture with static examples which caused actual problem
  • I think it may be handy to have two different fixtures - pets and todos
  • having that I could prepare a test which fails when bug exists and passes when it's fixed

XVincentX
XVincentX approved these changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@XVincentX XVincentX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems way more reasonable! Thanks!

@karol-maciaszek
Copy link
Contributor Author

This seems way more reasonable! Thanks!

You right :) Thanks!

@karol-maciaszek karol-maciaszek merged commit bbf6492 into develop Apr 2, 2019
@karol-maciaszek karol-maciaszek deleted the fix/SL-2192/stringify-examples branch April 2, 2019 09:41
@XVincentX XVincentX mentioned this pull request May 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XVincentX XVincentX XVincentX approved these changes

@chris-miaskowski chris-miaskowski Awaiting requested review from chris-miaskowski

@philsturgeon philsturgeon Awaiting requested review from philsturgeon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karol-maciaszek @XVincentX