-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/sl 2192/stringify examples #205
Conversation
# Conflicts: # packages/core/src/factory.ts # packages/core/src/utils/__tests__/__snapshots__/configMergerFactory.spec.ts.snap # packages/core/src/utils/__tests__/configMergerFactory.spec.ts # packages/core/src/utils/configMergerFactory.ts # packages/core/src/utils/resolveConfig.ts # packages/http-server/src/getHttpConfigFromRequest.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think we need a new whole fixture; the functional snapshot changes look enough to me.
|
…io/prism into fix/SL-2192/stringify-examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems way more reasonable! Thanks!
You right :) Thanks! |
Issue: https://stoplightio.atlassian.net/browse/SL-2192
The cause of freeze was that fastify received object as a response body instead of string. This PR enforces response body to be stringified.