Fixes for Node version 6 #57
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes stormpath/express-stormpath#438
@typerandom so here's the deal: the
cloneextend
module was callinghasOwnProperty()
directly on objects, and that is brittle. Why this became a problem in node v6 I'm not sure and I didn't dig into it. But someone did fix this issue here, by using a more robust method for checking an object for properties:https://github.com/shimondoodkin/nodejs-clone-extend/pull/5/files
Using that commit does solve the problem in stormpath/express-stormpath#438. That library isn't maintained very well, e.g. master has breaking changes in it, and package.json has a bumped minor number, which isn't even in npm anyways. As such, I'm moving the author's code into this library so that we aren't depending on a fragile library.
Other changes in this PR: