This repository was archived by the owner on Jan 7, 2019. It is now read-only.
ID Site Authentication #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
nikone
reviewed
Oct 31, 2016
| callback_url = Stormpath::Rails::Client.application.create_id_site_url( | ||
| callback_uri: root_url, | ||
| logout: true | ||
| ) |
There was a problem hiding this comment.
would move to a seperate method
private
def callback_url
Stormpath::Rails::Client.application.create_id_site_url(
callback_uri: id_site_result_url,
path: Stormpath::Rails.config.web.id_site.login_uri
)
end
nikone
reviewed
Oct 31, 2016
| callback_uri: id_site_result_url, | ||
| path: Stormpath::Rails.config.web.id_site.login_uri | ||
| ) | ||
| redirect_to callback_url |
There was a problem hiding this comment.
would move to a seperate method
private
def callback_url
Stormpath::Rails::Client.application.create_id_site_url(
callback_uri: id_site_result_url,
path: Stormpath::Rails.config.web.id_site.login_uri
)
end
nikone
reviewed
Oct 31, 2016
| callback_uri: id_site_result_url, | ||
| path: Stormpath::Rails.config.web.id_site.register_uri | ||
| ) | ||
| redirect_to callback_url |
There was a problem hiding this comment.
would move to a seperate method
private
def callback_url
Stormpath::Rails::Client.application.create_id_site_url(
callback_uri: id_site_result_url,
path: Stormpath::Rails.config.web.id_site.login_uri
)
end
nikone
reviewed
Oct 31, 2016
| end | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
👍 nice one :D
but it would be good to also have remove method covered with service specs
…d cookies cleaner
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for issue #54
The implementation is working, but currently only request and unit specs are present. We need to add specs that mock the behaviour that's occurring on the Stormpath ID Site (authentication etc...).