This repository was archived by the owner on Jan 7, 2019. It is now read-only.
Replace existing code for controller authentication with the Ruby SDK #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
1 similar comment
|
Pull request ready for review @DamirSvrtan :) |
DamirSvrtan
reviewed
Nov 8, 2016
Gemfile
Outdated
|
|
||
| gem 'sqlite3', '~> 1.3' | ||
| gem 'sass-rails' | ||
| gem 'stormpath-sdk' |
There was a problem hiding this comment.
Please remove this as it should not be necessary.
| def authenticate! | ||
| begin | ||
| AccountFromAccessToken.new(bearer_access_token).account | ||
| rescue *RESCUE_CLASSES |
There was a problem hiding this comment.
Create a request spec called 'authentication_spec' where you ping the me route and you check to see if the errors raised from ControllerAuthentication get saved in the Controller. Failing specs first.
There was a problem hiding this comment.
Spec created @DamirSvrtan
…username even more
1 similar comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for issue #62
Currently there's one test failing in the controller authentication because of raising not specific errors in the Ruby SDK. Merge this PR after the Ruby SDK's error handling is properly refactored.