Skip to content
This repository has been archived by the owner on Dec 12, 2018. It is now read-only.

Stormpath Spring Boot Auto Configuration Controller Endpoint Conflicts #1164

Open
andersonkyle opened this issue Dec 8, 2016 · 1 comment

Comments

@andersonkyle
Copy link

andersonkyle commented Dec 8, 2016

Stormpath Spring Boot Auto Configuration should be more mindful of User Configuration, specifically Controller Mappings (e.g. @RequestMapping).

If Stormpath attempts to register a mapping that already exists in User Configuration, the application should fail at startup to remain consistent with Spring Boot behavior regarding conflicting Controller Endpoints.

The current behavior is the Stormpath endpoint silently overrides the one defined by the User. This was discovered while researching #1160

@andersonkyle
Copy link
Author

I've created a fix for this in PR #1165

I'm still not in love with the way that Stormpath creates mappings. Spring isn't aware of these mappings, so they don't show up in the Actuator endpoints, logs, etc. If I'm leveraging the Spring Framework, I want my Application Context to be aware of everything. Had this been the case the above fix would've been unnecessary.

That may require more refactoring so I'd like to get your thoughts on it. But in the meantime I think the PR mentioned above is a reasonable interim fix.

andersonkyle pushed a commit to andersonkyle/stormpath-sdk-java that referenced this issue Jan 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants