Add onCollapsedChange prop for Doc Block
#217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<#216> This event callback enables users to save collapsed state and use it for `defaultCollapsed` property. Having an event for changes is necessary as the collapsed state is uncontrolled property.
yannbf
approved these changes
Nov 2, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #216
Added
onCollapsedChangeproperty forDocBlockBasecomponent, which is used by every Doc Block components.This enables users (story authors) to persist collapsed state somewhere and restore it via
defaultCollapsedproperty, in order to save users' screen estate.I choose to use
onObjectVerbnaming style commonly used in DOM, but willing to change if official Storybook code/community has widely used style.