docs(styleguide): auto-collapse Figma embed for known non-Codecademy-admin user #2795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
JoshuaKGoldberg
commented
Oct 12, 2023
Comment on lines
+14
to
+17
| onClick={(event) => { | ||
| console.log("Without an onClick, is this where we'd save preference?"); | ||
| console.log('DOM event:', event); | ||
| }} |
There was a problem hiding this comment.
Pending storybookjs/addon-designs#216 and/or my ability to run this all locally.
There was a problem hiding this comment.
Now that storybookjs/addon-designs#217 is in, once Gamut is updated to the latest Storybook then we can get this working!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Auto-collapses the Figma embed in Storybook docs pages if the Codecademy user is loaded and not an admin.
Context: I'd like to show off Gamut to people in my talks about design systems. But the giant Figma embeds are getting in the way for non-employees like me. I chatted with @dreamwasp who chatted with the team about the strategy in this PR: auto-collapsing them by default if we know the user isn't a Codecademy admin.
I'm getting
Uncaught Error: Cannot find module '@codecademy/variance'locally (and yes, I didyarn buildfrom the root). So I haven't tried it out locally.PR Checklist
I can't do any of these things :c
Testing Instructions
Don't make me tap the sign.
PR Links and Envs
i don't know what all this is :c sorry