-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for SB8 #63
Update for SB8 #63
Conversation
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
@JReinhold It could very well work.. But before proceeding to merge this, please try it out in detail. If you create a dummy addon that uses a preset, does storybook correctly load it? |
Tested this out extensively with @ndelangen and we concluded that everything works and we can even clean up a bunch of files because of it. |
@SocketSecurity ignore npm/defaults@1.0.4 |
This PR does a lot of maintenance tasks to the template:
nodeEntries
bundle entry for bundling presets and other Node-only entries.preview
entries as they might be imported in Portable Stories scenarios.type = module
)