-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom HTML for iframe (was 'Using Typekit') #61
Comments
Yes. This would be something great. We could have a file in the .storybook directory as base.html and use it in the iframe. |
Also useful for any other CDN links, e.g. Font Awesome. |
I've started a PR to enable adding custom html to the iframe, I'd appreciate anyone's thoughts on whether I'm headed in the right direction! |
Check version: |
Just to clarify, #77 seems to only cover the |
@peisenmann just wrap your story with that div/class. Thanks for this. Useful for google maps. |
I think we can close this now. |
Make render function of WrapStory pure
At work we use typekit to load fonts for our components. They are loaded using the simple Typekit embed code (as seen here: https://helpx.adobe.com/typekit/using/embed-codes.html).
The embed code is two script tags like the following:
I'm not sure of the best route for adding these script tags in to React Storybook, and wondered if anyone had any ideas!
Would React Storybook be interested in supporting customising the HTML of the iframe to enable the script tags to be added. This would also be useful for loading some external CSS that our components currently depend on.
The text was updated successfully, but these errors were encountered: