Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Detect arg inference for cyclic args and warn #13263

Merged
merged 4 commits into from
Nov 25, 2020
Merged

Core: Detect arg inference for cyclic args and warn #13263

merged 4 commits into from
Nov 25, 2020

Conversation

shilman
Copy link
Member

@shilman shilman commented Nov 25, 2020 •
edited
Loading

Issue: #13242

What I did

Check for cycles!

How to test

See new official-storybook story. Self-merging @tmeasday

@shilman shilman added this to the 6.1.x milestone Nov 25, 2020
@Marklb Marklb mentioned this pull request Nov 25, 2020
Closed
gaetanmaisse
gaetanmaisse approved these changes Nov 25, 2020
View reviewed changes
Copy link
Member

@gaetanmaisse gaetanmaisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪🏻

@shilman shilman merged commit 2f059cb into next Nov 25, 2020
@shilman shilman deleted the 13242-fix-cyclic-args branch November 25, 2020 14:21
@shilman shilman mentioned this pull request Nov 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaetanmaisse gaetanmaisse gaetanmaisse approved these changes

@usulpro usulpro Awaiting requested review from usulpro

Assignees
No one assigned
Labels
args bug
Projects
None yet
Milestone
6.1.x
Development

Successfully merging this pull request may close these issues.
2 participants
@shilman @gaetanmaisse