Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte: Statically load docgen info for svelte components #13466

Merged
merged 1 commit into from
Dec 16, 2020

Conversation

j3rem1e
Copy link
Contributor

@j3rem1e j3rem1e commented Dec 16, 2020

Issue: #13247

What I did

Every svelte component has now a static __docgen property.
I have upgraded the svelte kitchen sink to use controls in order to test it

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@shilman shilman added svelte bug patch:yes Bugfix & documentation PR that need to be picked to main branch labels Dec 16, 2020
@shilman shilman changed the title Make docgen static for svelte component (fixes #13247) Svelte: Make docgen static for svelte component Dec 16, 2020
@shilman shilman added this to the 6.1.x milestone Dec 16, 2020
@shilman shilman changed the title Svelte: Make docgen static for svelte component Svelte: Statically load docgen info for svelte components Dec 16, 2020
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work @j3rem1e. much better! 💯

@shilman shilman merged commit 974fd14 into storybookjs:next Dec 16, 2020
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jan 12, 2021
shilman added a commit that referenced this pull request Jan 12, 2021
Svelte: Statically load docgen info for svelte components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch svelte
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants